-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't exclude arm64-v8a libraries #8326
Conversation
Pull Request Checklist
|
Not sure why we build for |
Jenkins BuildsClick to see older builds (65)
|
100% of end-end tests have passed
Passed tests (49)Click to expand |
100% of end-end tests have passed
Passed tests (49)Click to expand |
@jakubgs is it expected? Android 8 |
realm strikes again 😭 |
Also:
Great solution, nice. Upgrading Realm really might help. |
@jakubgs sounds like should help me market my PR :) |
@asemiankevich can you please check it out now? I've rebased it on the changes introduced by #8336. |
@jakubgs are there any news for this PR? I can see you've added "release" label recently but there are no new builds/updates. Do you expect to add them soon? cc @rachelhamlin |
@annadanchenko I don't know how to fix this. If you look at facebook/react-native#24261 there are still people there complaining that 64 bit builds do not work due to react-native, I do not know what to do about that. |
@annadanchenko I think an Android dev should take over this task, because I don't know enough about Android apps to understand why enabling I thought the issue was the old JSC that was used in React-Native before |
so it doesn't work on samsung s10 as well, but i've tried it on readmi note 3 and it works randomly sometimes it stucks in different places (logo screen, generating accounts, or request messages), but sometimes it works pretty well |
these logs when it doesn't get stuck |
dd84a21
to
520c159
Compare
Those logs tell me nothing, I'm not an android dev. |
Why are you adding |
@jakubgs i'm not sure https://medium.com/@andriidrozdov/reactnative-and-android-64-bit-new-google-play-market-rules-what-to-do-584b067d6f1a |
80% of end-end tests have passed
Failed tests (9)Click to expand
Passed tests (35)Click to expand |
Incorrect:
|
@flexsurfer https://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-190726-151832-03aa67-pr.apk in this build installation works on huawei -> but then i see endless spinner on Chats and app is not responsive on Xiaomi i am stuck on password creation -> app is not responsive (back button for ex) and Next is not active. Navigation is very slow in this build on my devices, and for example i can end up here when switching between tabs (huawei) - wallet sign phrase in Chat tab. |
we've tested version without realm https://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-190729-090042-498654-pr.apk , from this PR #8528 , it still has the same problem |
Signed-off-by: Jakub Sokołowski <jakub@status.im>
03aa67c
to
06d8d33
Compare
What's the state of this PR and how does this relate to the existing debugging work for arm64? It's been open for quite a while now so I'd suggest closing this particular PR if we can't get it merged this week. |
Closing this as I'm working to upgrade to Hermes in #8672, which should fix the issue as shown in https://github.com/PombeirP/arm64-hang-repro-app. Also created a bug report in RN: facebook/react-native#25970 |
For some reason we were already building for
arm64-v8a
, but we were excluding the built libraries from the resulting APK bundle.Fixes: #8292